-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design): move each button type to its own component #3328
Conversation
@damienwebdev The Since each component example is only importing the specific button type (i.e. DaffFlatButtonComponent), the
|
@xelaint I think that's perfectly fine. While the prefix suffix code is tiny, we still don't want to encourage people to import code they don't use. If they want to use prefix and suffix, they can import it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #3196
What is the new behavior?
Does this PR introduce a breaking change?
Other information