Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): implement article encapsulated mixin in DaffTreeComponent and add docs to design-land #2771

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Mar 25, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Article styles will override tree styles, especially tree items that are linked.

Part of: #2767

What is the new behavior?

the daffArticleEncapsulatedMixin is implemented in the tree component so that article styles do not get passed down into tree items.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Mar 25, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Mar 25, 2024
@xelaint xelaint requested a review from a team as a code owner March 25, 2024 21:45
@xelaint xelaint merged commit baa150e into develop Mar 26, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Mar 26, 2024
@damienwebdev damienwebdev deleted the tree-update branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant