-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal UI updates #2832
Closed
Closed
Modal UI updates #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xelaint
added
package: design
@daffodil/design
status: awaiting review
This PR is awaiting review
labels
Jun 6, 2024
damienwebdev
force-pushed
the
modal-ui-updates
branch
from
July 17, 2024 14:11
ba46e9d
to
47336cf
Compare
xelaint
force-pushed
the
modal-ui-updates
branch
2 times, most recently
from
July 17, 2024 14:15
ba46e9d
to
4315111
Compare
damienwebdev
requested changes
Jul 17, 2024
libs/design/modal/src/modal-close/modal-close.directive.spec.ts
Outdated
Show resolved
Hide resolved
xelaint
force-pushed
the
modal-ui-updates
branch
from
July 18, 2024 15:53
260bf1a
to
33d12fe
Compare
@xelaint this looks good to me. Can you fixup the commits and I'll merge this in directly? |
xelaint
force-pushed
the
modal-ui-updates
branch
from
July 19, 2024 15:41
33d12fe
to
be756e3
Compare
@damienwebdev done |
xelaint
force-pushed
the
modal-ui-updates
branch
from
July 19, 2024 15:46
be756e3
to
187bcfd
Compare
xelaint
added
status: awaiting merge
This PR has met all the requirements for merge and is waiting on an admin
and removed
status: awaiting review
This PR is awaiting review
labels
Jul 22, 2024
damienwebdev
force-pushed
the
modal-ui-updates
branch
from
July 23, 2024 14:38
187bcfd
to
1dccde1
Compare
damienwebdev
pushed a commit
that referenced
this pull request
Jul 23, 2024
damienwebdev
pushed a commit
that referenced
this pull request
Jul 23, 2024
This adds a close button to the DaffModalCHeaderComponent and allows the close button to be reusable
damienwebdev
pushed a commit
that referenced
this pull request
Jul 23, 2024
damienwebdev
force-pushed
the
modal-ui-updates
branch
from
July 23, 2024 14:40
1dccde1
to
2b96d4d
Compare
Merged
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: design
@daffodil/design
status: awaiting merge
This PR has met all the requirements for merge and is waiting on an admin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Part of: #2767
What is the new behavior?
daffModalClose
directive to pass in close modal event to a button to reduce code duplication. It's used in the close button in the header, and enduser can pass it into a<button>
element in the actions component to also close the modal.Does this PR introduce a breaking change?
Other information