Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal UI updates #2832

Closed
wants to merge 0 commits into from
Closed

Modal UI updates #2832

wants to merge 0 commits into from

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 6, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  1. Accessibility features are not comprehensive enough in modal.
  2. No easy way to add button to close modal

Part of: #2767

What is the new behavior?

  1. daffModalClose directive to pass in close modal event to a button to reduce code duplication. It's used in the close button in the header, and enduser can pass it into a <button> element in the actions component to also close the modal.
  2. Update UI with considerations on if header and footer is used or not.
  3. Add close button to header.
  4. Clean up and update docs.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

libs/design/modal/README.md Outdated Show resolved Hide resolved
libs/design/modal/src/modal-close/modal-close.directive.ts Outdated Show resolved Hide resolved
libs/design/modal/README.md Outdated Show resolved Hide resolved
libs/design/modal/src/modal/modal.component.ts Outdated Show resolved Hide resolved
libs/design/modal/src/modal-title/modal-title.directive.ts Outdated Show resolved Hide resolved
@damienwebdev
Copy link
Member

@xelaint this looks good to me. Can you fixup the commits and I'll merge this in directly?

@xelaint
Copy link
Member Author

xelaint commented Jul 19, 2024

@damienwebdev done

@xelaint xelaint added status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin and removed status: awaiting review This PR is awaiting review labels Jul 22, 2024
damienwebdev pushed a commit that referenced this pull request Jul 23, 2024
This adds a close button to the DaffModalCHeaderComponent
and allows the close button to be reusable
@damienwebdev damienwebdev deleted the modal-ui-updates branch July 23, 2024 14:40
@gray-bot gray-bot mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants