Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): remove deprecated tag on onBackdropClicked in DaffSidebarViewportBackdropComponent #2874

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There is a deprecated tag on onBackdropClicked in DaffSidebarViewportBackdropComponent

Part of: #2853

What is the new behavior?

Remove the deprecated tag on onBackdropClicked because it's necessary.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jun 14, 2024
@xelaint xelaint requested a review from a team as a code owner June 14, 2024 18:06
@xelaint xelaint merged commit c2912d8 into develop Jun 14, 2024
13 checks passed
@damienwebdev damienwebdev deleted the sidebar-remove-deprecation branch October 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant