Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): add scrollOffset so headings are not covered by the navbar #2929

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jul 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint xelaint added the package: daff.io @daffodil/daff.io label Jul 22, 2024
@xelaint xelaint requested review from a team as code owners July 22, 2024 20:25
@xelaint xelaint added the status: awaiting review This PR is awaiting review label Jul 22, 2024
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit bf21aab into develop Jul 23, 2024
8 checks passed
@damienwebdev damienwebdev deleted the anchor-scroll-offset branch July 23, 2024 14:30
@gray-bot gray-bot mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants