Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(external-router): extract daff paths ignoring full path #2955

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

daffExtractDaffPathData ignores all routes in the path except the last, incorrectly building the path when the last route is an empty path route.

What is the new behavior?

daffExtractDaffPathData computes the path from all routes in the path from root.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added package: external-router @daffodil/external-router layer: routing This PR or issue is related to the routing layer status: awaiting review This PR is awaiting review labels Aug 5, 2024
@griest024 griest024 requested a review from a team as a code owner August 5, 2024 21:30
@griest024
Copy link
Member Author

@damienwebdev is this the behavior that we actually want?

@griest024 griest024 requested a review from damienwebdev August 7, 2024 13:58
@griest024 griest024 mentioned this pull request Aug 7, 2024
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 961512d into graycoreio:develop Aug 7, 2024
9 checks passed
@griest024 griest024 deleted the fix/external-router/extract-daff-paths-ignoring-last-child branch August 8, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: routing This PR or issue is related to the routing layer package: external-router @daffodil/external-router status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants