Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): create DaffTabsComponent #3134

Merged
merged 12 commits into from
Oct 28, 2024
Merged

feat(design): create DaffTabsComponent #3134

merged 12 commits into from
Oct 28, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Oct 1, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Component doesn't exist and is needed for docs.

Fixes: #3123

TO DO:

  • aria-labelledby needs to be set on <daff-tab-panel> by the id of the corresponding <daff-tab>
  • aria-controls set on <daff-tab> using the unique id
  • Keyboard accessibility

Expect implementation code to be like this


<daff-tabs>
  <button daff-tab>Tab 1</button>
  <button daff-tab>Tab 2</button>
  <button daff-tab>Tab 3</button>
  <button daff-tab>Tab 4</button>
  <daff-tab-panel>Tab 1 Content</daff-tab-panel>
  <daff-tab-panel>Tab 2 Content</daff-tab-panel>
  <daff-tab-panel>Tab 3 Content</daff-tab-panel>
  <daff-tab-panel>Tab 4 Content</daff-tab-panel>
</daff-tabs>

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft. labels Oct 1, 2024
@xelaint xelaint self-assigned this Oct 1, 2024
@xelaint xelaint marked this pull request as ready for review October 10, 2024 15:16
@xelaint xelaint requested a review from a team as a code owner October 10, 2024 15:16
@xelaint xelaint added status: awaiting review This PR is awaiting review and removed status: wip This PR is WIP. It should be marked as a draft. labels Oct 10, 2024
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@damienwebdev damienwebdev merged commit ffe6c19 into develop Oct 28, 2024
13 checks passed
@damienwebdev damienwebdev deleted the tabs-component branch October 28, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Tabs Component
3 participants