Use the latest Cosmiframe version with security features #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingki
reviewed
May 8, 2024
| useGrazInternalStore.getState()._notFoundFn(); | ||
| throw new Error("not in iframe"); | ||
| } | ||
|
|
||
| const keplr = new Cosmiframe().getKeplrClient(); | ||
| const keplr = new Cosmiframe(["https://daodao.zone", "https://dao.daodao.zone"]).getKeplrClient(); |
There was a problem hiding this comment.
what if we expose this options in GrazProvider?
There was a problem hiding this comment.
oh sure that'd be great
NoahSaso
force-pushed
the
noah/upgrade-cosmiframe
branch
3 times, most recently
from
e91adb6
to
59c9b15
Compare
NoahSaso
force-pushed
the
noah/upgrade-cosmiframe
branch
from
59c9b15
to
bece998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cosmiframe previously lacked origin restrictions that meant any parent window could control the app, potentially allowing for MITM attacks.
This updates it to the latest version which requires strict origin filters.
Since Graz does not currently provide any way for clients to specify custom options for a given wallet adapter, I just changed the Cosmiframe wallet to a DAO DAO-specific wallet which only works on trusted DAO DAO domains. This can be extended later if other parent apps want to integrate with Graz.