Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angular universal server side rendering issue #77 #90

Closed
wants to merge 5 commits into from

Conversation

fadelguy
Copy link

@fadelguy fadelguy commented Apr 3, 2018

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
document is not defined in angular universal server side

What is the new behavior?
no errors.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@MatejBivr
Copy link

Hi, any updates on when this will be merged?

@zolakt
Copy link

zolakt commented Jul 2, 2018

Any updates?
I see no workaround since it crashes as soon as you import the module

@Enslev
Copy link

Enslev commented Feb 26, 2019

Has this PR been forgotten?
Any updates on if this bug will be fixed?

@un1c0rnr1d3r
Copy link
Collaborator

SSR support was added in PR #159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants