Support capture SurfaceView on Android #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use PixelCopy to include content of SurfaceView in screenshot * Disable SurfaceView screenshot by default, but allow to enable it Co-authored-by: Alexande B <abobrikovich@gmail.com>
* Use react-native-video v6 alpha (Use the exoplayer intergration by default) * Add another video view and enable surface view mode
|
@gre Please review this. Thanks! |
jhen0409
force-pushed
the
support-android-surface
branch
from
c4a5fab to
68253d5
Compare
gre
approved these changes
Aug 20, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues of #323.
PixelCopy.requestto capture SurfaceView contentuseTextureView={false}to use surface view (ref: https://github.com/react-native-video/react-native-video/blob/08c2220e1663808a7bac76babc404b51154a50af/android/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java#L107)