Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix lack of formatting in actions.py #10918

Merged

Conversation

JessSaavedra
Copy link
Contributor

@JessSaavedra JessSaavedra commented Feb 6, 2025

Description

As params does not support inline code blocks, some examples inside the paremeters are causing the styling to break. We decided to move that below into an examples section

Deploy preview links

EmailAction
SlackNotification

Screenshots

Before

image
image

After

image
image

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 4046494
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/67acce974a968600080b390c
😎 Deploy Preview https://deploy-preview-10918.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.77%. Comparing base (710167a) to head (4046494).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10918      +/-   ##
===========================================
- Coverage    80.77%   80.77%   -0.01%     
===========================================
  Files          465      465              
  Lines        40620    40620              
===========================================
- Hits         32812    32811       -1     
- Misses        7808     7809       +1     
Flag Coverage Δ
3.10 70.13% <ø> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.51% <ø> (?)
3.10 aws_deps 46.41% <ø> (?)
3.10 big 54.91% <ø> (?)
3.10 bigquery 48.66% <ø> (?)
3.10 clickhouse 43.30% <ø> (?)
3.10 databricks 50.44% <ø> (?)
3.10 filesystem 62.87% <ø> (?)
3.10 mssql 51.45% <ø> (?)
3.10 mysql 51.83% <ø> (?)
3.10 postgresql 54.47% <ø> (?)
3.10 snowflake 51.19% <ø> (?)
3.10 spark 57.80% <ø> (?)
3.10 spark_connect 46.74% <ø> (?)
3.10 trino 52.37% <ø> (?)
3.11 70.11% <ø> (-0.02%) ⬇️
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.51% <ø> (?)
3.11 aws_deps 46.41% <ø> (?)
3.11 big 54.91% <ø> (?)
3.11 bigquery 48.66% <ø> (?)
3.11 clickhouse 43.30% <ø> (?)
3.11 databricks 50.44% <ø> (?)
3.11 filesystem 62.87% <ø> (?)
3.11 mssql 51.45% <ø> (?)
3.11 mysql 51.83% <ø> (?)
3.11 postgresql 54.47% <ø> (?)
3.11 snowflake 51.19% <ø> (?)
3.11 spark 57.80% <ø> (?)
3.11 spark_connect 46.74% <ø> (?)
3.11 trino 52.37% <ø> (?)
3.12 70.13% <ø> (+0.01%) ⬆️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.52% <ø> (ø)
3.12 aws_deps 46.41% <ø> (ø)
3.12 big 54.90% <ø> (ø)
3.12 bigquery 48.67% <ø> (ø)
3.12 databricks 50.44% <ø> (ø)
3.12 filesystem 62.87% <ø> (ø)
3.12 mssql 51.45% <ø> (ø)
3.12 mysql 51.83% <ø> (ø)
3.12 postgresql 54.47% <ø> (ø)
3.12 snowflake 51.19% <ø> (ø)
3.12 spark 57.80% <ø> (ø)
3.12 spark_connect 46.74% <ø> (ø)
3.12 trino 52.38% <ø> (ø)
3.9 70.14% <ø> (ø)
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.51% <ø> (ø)
3.9 aws_deps 46.43% <ø> (ø)
3.9 big 54.92% <ø> (ø)
3.9 bigquery 48.66% <ø> (ø)
3.9 clickhouse 43.31% <ø> (ø)
3.9 databricks 50.44% <ø> (-0.01%) ⬇️
3.9 filesystem 62.87% <ø> (ø)
3.9 mssql 51.43% <ø> (ø)
3.9 mysql 51.81% <ø> (ø)
3.9 postgresql 54.46% <ø> (ø)
3.9 snowflake 51.19% <ø> (ø)
3.9 spark 57.77% <ø> (ø)
3.9 spark_connect 46.75% <ø> (ø)
3.9 trino 52.36% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 54.00% <ø> (ø)
docs-creds-needed 52.87% <ø> (ø)
docs-spark 52.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessSaavedra JessSaavedra added this pull request to the merge queue Feb 12, 2025
Merged via the queue into develop with commit df0a2d0 Feb 12, 2025
102 checks passed
@JessSaavedra JessSaavedra deleted the DOC-919_occasional_lack_of_formatting_in_api_docs branch February 12, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants