Skip to content

Commit

Permalink
Merge pull request #915 from deanoemcke/revert-914-feature/unsuspend-…
Browse files Browse the repository at this point in the history
…active-tabs-before-update

Revert "Unsuspended tabs before update (#895)"
  • Loading branch information
deanoemcke authored Apr 7, 2019
2 parents 9d26509 + 6d58cc4 commit dc1ad6e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
10 changes: 0 additions & 10 deletions src/js/gsSession.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ var gsSession = (function() {
if (!sessionRestorePoint || suspendedTabCount > 0) {
//show update screen
await gsChrome.tabsCreate(updateUrl);
//ensure we don't leave any windows with no unsuspended tabs
await unsuspendActiveTabInEachWindow();
} else {
// if there are no suspended tabs then simply install the update immediately
chrome.runtime.reload();
Expand Down Expand Up @@ -793,13 +791,6 @@ var gsSession = (function() {
return sessionMetrics;
}

async function unsuspendActiveTabInEachWindow() {
const activeTabs = await gsChrome.tabsQuery({ active: true });
for (let activeTab of activeTabs) {
tgs.unsuspendTab(activeTab);
}
}

return {
initAsPromised,
runStartupChecks,
Expand All @@ -820,6 +811,5 @@ var gsSession = (function() {
prepareForUpdate,
getUpdateType,
updateSessionMetrics,
unsuspendActiveTabInEachWindow,
};
})();
2 changes: 0 additions & 2 deletions src/js/update.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
currentVersion
);
}
//ensure we don't leave any windows with no unsuspended tabs
await gsSession.unsuspendActiveTabInEachWindow();
chrome.runtime.reload();
// }
};
Expand Down

0 comments on commit dc1ad6e

Please sign in to comment.