Tab icon replaced with extension icon and text replaced with "Suspended Tab"

[nomennescio]

The idea of this extension is great; keep lots of tabs open, while automatically saving memory.

However, I regularly have +- 50 windows with each 20 tabs open, as reference material.
To quickly switch to a needed tab, I first Alt-TAB to a window, then select a tab.
HOWEVER, when using this extension, all suspended tabs will get their tab icon and tab text replaced.
This makes selecting a suspended tab IMPOSSIBLE without going through ALL suspended tabs.

As it now is, the webpage itself shows a text about the page being suspended and needing a reload,
so why not just KEEP the original tab icon and text? That would solve this issue very simply.

[nomennescio]

Interestingly, it seems this is already PARTIALLY implemented.
If I enable suspending, and set it to 20 seconds, then ALL tabs will be suspended after 20 secs,
and ALL icons and tab texts are replaced. This makes this extensions practically unusable.

HOWEVER, if I now "disable" suspending, by setting the timeout to "never", all icons reappear,
WHILE the webpages are STILL suspended.

Hence, to implement this feature, just do not overwrite tab icons and tab text when suspending it.

If wanted, you can make this into a customizable option.

[penn5]

I believe this is already FULLY implemented.
After tabs suspend for me, they shortly display "Suspended Tab", but quickly change to the original. The icon is the same but faded.

[PlayerPL]

Not sure. I have same situation as nomennescio.

[bja-au]

G'day - I'm having the same problem - didn't happen with the previous version. Is there any way I can install the previous version (6.21??) please? Thanks bja

[deanoemcke]

This is a bug. Due to the way that tabs are suspended, it is impossible to display the correct icon and title instantly, however, as soon as the page loads, the icon and text should be replaced. In normal circumstances this is almost instantaneous.
@nomennescio @PlayerPL @bja-au Are any of you able to check out the chrome developer console on one of the suspended pages that is not updating the icon?
I suspect there will be some errors in the console of these pages. It would be really useful to know what is happening here.

[deanoemcke]

Even though I cannot reproduce, I will assume that this issue will be made redundant by the upcoming release v7.x

[liv-in-sky]

hi,

I'm using chrome canary version 71 with great suspender version 7.0.109 - I also have chrome 69 with suspender. in canary I have this issue - After starting canary some of the tab icons have the suspender icon - some not. I have to click the tab and it will change to the right icon. in chrome 69 I don't have this issue.
- Any hints what to do ?

[fwextensions]

@liv-in-sky, there was a fix for that committed a few weeks ago as part of #719, but I don't think that version has been released yet. You could try loading the most recent version from master.

[liv-in-sky]

thanx for this - I have tried and it worked - I have now two greatsuspender-extensions but I disabled the "regular" one.

[liv-in-sky]

I was a little bit too fast - It is working after starting the chrome canary browser but after a few hours working with my computer: suddenly some of the tab-icons are dissapeared and the suspender-icon was shown.

[fwextensions]

@liv-in-sky, this is without restarting the canary build? Do you have the Automatic tab discarding flag set differently between the two versions of Chrome? Also, which OS are you on?

[liv-in-sky]

hi ,

• I can't say if I restartet the canary during the day (80% for yes)

• I did some work on my pc and after a few hours the icons where gone - I also have the problem this morning - see picture
  

• chrome canary flag is default - in chrome is enabled - I will change the flag to enable in canary and will give you feedback

[liv-in-sky]

I restartet - all Icons are right (flag enable like in regular chrome) - what is the right setting for this flag - enabled or disabled? - both chrome versions now on: enabled

I'm on windows 10 - 64bit

thanx for your help

[fwextensions]

I thought the default setting would've been enabled, so it's strange that explicitly setting it to enabled made any difference. But glad it helped.

[liv-in-sky]

hi
at the moment - I have to restart chrome canary every morning before all icons are shown. after power on and starting canary - the "regular" icons aren't shown (all have "suspender" icons) - then restart canary - all icons are back - every morning !

[fwextensions]

Strange. I used to see that issue on Win7 with the old version of the extension, but I haven't seen it on v110 on Win10. Have you pulled the latest version from master recently? And this is working fine on Chrome 69, but not on canary?

From @deanoemcke's comment above, it sounds like he thought this was fixed, so maybe he can do some more debugging with you.

[liv-in-sky]

hi

version 7.0.122 and Version 71.0.3568.0 (Offizieller Build) canary (32-Bit) - still have to restart canary after shwitch on the pc

[deanoemcke]

@liv-in-sky can you please walk me through your situation in a bit more depth?

beginning at the night before, you have chrome canary open with some tabs:

• how many tabs? in how many windows? how many of those are suspended?
• do you close chrome canary? or power down your computer? or simply close the lid?

then in the morning:

• are you restarting/opening the lid of your computer and canary reappears? or are you manually restarting canary and it is 'continuing where you left off'?

i assume this is the point where you're finding that some tabs do not recover their favicons:

• how are you restarting canary at this point that fixes the issue?

Thanks for the details, it will greatly help me diagnose your issue.

[liv-in-sky]

the data:
I open 3 windows - by default - I close the browser with exit to keep the tabs saved.
1: 3 tabs
2: about 30
3: about 20
I have changed canary to 64 bit - same situation - I did the same in chrome - no problem

"the whole story" - I used chrome - over the time - chrome run very slow and unstable - (I do a lot of research and also open a lot of web-admin tools ) - In order to NOT loose all my settings I decided to install canary. During switch on the PC: At he moment chrome is opening automatically (I don't know why ?:-( ). then I have to open canaryby clicking the icon. only a couple (4 or 5 icons) are shown right. then I exit canary and start it again - all icons are there. overall I have 3 canary windows and one chrome window. I will now try the following: deinstall great suspender on both "chromes" (because of sync). restart the computer - stop chrome - open canary

[deanoemcke]

hmmm.. i think for simplicity's sake, we can just ignore your normal chrome application. the two shouldn't have any effect on each other.

so you have canary open with 3 windows containing about 53 tabs.
then you close canary with the chrome->exit option.
then you restart canary and it doesn't restore all your icons.
then you close canary again (with the chrome->exit option?)
then you restart canary again and all your icons appear ok.

is that a good summary?
can i assume that before closing canary the first time you have some suspended tabs.
and then when you restart, those suspended tabs don't show the proper icons.
and finally on the next restart, you still have those suspended tabs but they show the correct icons?

[liv-in-sky]

I think your assuming is right

what I did yesterday

• update to canary 64 bit - > icons not working
• deinstalled suspender on chrome and canary (because of the sync?!)
• installing again - > icons not working (even more worse - icons aren't shown after restart canary)
• loaded all tabs and disabled suspender
• saved tabs and closed a lot of them
• restarted and enabled suspender

today morning everthing worked fine - all icons are shown. I have 3 windows with 60 tabs. My estimation is that closing the tabs and the start with "cleaned" tabs was the solution - I will see what the weekend will bring

in any case - thanx for your time

[liv-in-sky]

me again - this was happened about 5 minutes ago

canary asked for an update - I have done this - then I have to restart canary - after the restart 50% of icons are missing.
solution: I have to unsuspend all tabs and this FOR EACH WINDOW ! then it is working again

[deanoemcke]

@liv-in-sky when you click on a tab with a missing icon, does the icon fix itself?

[liv-in-sky]

yes - by the way - this morning - everthing is fine

[liv-in-sky]

hi - good to know that it is not only my setting. I think it will be automatically updated or do I have to install something ?

thanx a lot - armin

[deanoemcke]

@liv-in-sky you will be updated automatically, although that might be a week away.

[deanoemcke]

I have made another optimistic fix for this issue (v7.0.133)

[deanoemcke]

And here is a nice video demonstrating the issue. Care of @CollinChaffin over in issue #784.
Thanks Collin :)

[mkz7]

Here is a related problem:

TABLI is a great extension for quickly locating a tab. However, the same issue already dealt with regarding tabs in the tab bar not being easily identifiable also affects TABLI's listings, making identification of tabs difficult there as well (you have to hover the mouse over the tab in order to identify it).

Currently, my TABLI listing is full of many suspended tabs that are 'normal' (clearly identified) and others that display only those long character strings, with no identification of content.

Hope you may be able to do something about that -- or that a fix for the tab bar will carry over to TABLI's tab listings (seems like it should).

Thanks.

[fwextensions]

@mkz7 I built a tab-switching Chrome extension called QuicKey that has special handling for tabs suspended by The Great Suspender. It doesn't have the session management features of Tabli, but it does make it easy to type a few characters to find a tab by its title or URL, or to navigate between recently used tabs. It renders suspended tabs differently its menu, lets you switch to one and unsuspend it with a keyboard shortcut, and it displays the correct title and favicon even if the tab just shows "Suspended Tab".

[liv-in-sky]

I can confirm the "tabli" issue - all chrome tabs have the right icons - in tabli they have the "suspender"-icons - I'm using another extension called "splitup" - everything is fine there (second picture)

[deanoemcke]

@mkz7 I looked into Tabli. The issue is to do with how their extension is obtaining the favicon to display in their list. If they were to query the chrome tabs api, they would be able to get the correct favicon, but they don't do this.

Just to keep things on topic, these last few posts should probably be discussed in a new thread as they're not specifically related to this issue.
This issue is for the favicon and/or title of actual suspended tabs. Not for a representation of those tabs elsewhere.

There is a related issue for missing favicon/titles on chrome synced devices: #46
And potentially this issue for missing favicon/titles in chrome://history: #717

[CollinChaffin]

Commit 369cc38 today has gotten 100% worse and does the opposite of fixing this issue that I and others are having with suspended tabs being manipulated via other tools and not having the favicon. I just updated to test and was really shocked to see that if I issue a single TGS command to simply suspend all tabs in the current window, EVERY SINGLE tab suspends with the blockhead icon - no favicon whatsoever. This issue seems to be getting worse and worse I have not diffed the code from a few months ago and I realize a ton of other refactoring is much of the cause of these changes, but bear in mind this whole ongoing favicon refresh issue did not even exist a couple months ago at all and my tabs stored in any other session manager suspended were stored with the proper icon, as well as a live suspend of all tabs changed their favicons properly upon suspend, so perhaps we need to revisit that codebase.

[CollinChaffin]

Just to give you a screen capture showing how a manual suspend now of any kind simply does not set the favicons at all (as of today's current commit 369cc38) this shows me first unsuspending all tabs using TGS (which works properly) followed by the failed manual suspend that does suspend, but now performs no favicon set and only the generic blockhead:

EDIT: 10-17-2018_02:38PM: I can confirm that the very latest commit 63a04dc from last night still renders the same results shown in my video above. :(

[CollinChaffin]

UPDATE: I can confirm this DOES in fact now revolve around the code related to the Apply Chrome's built-in memory-saving when suspending option as shown here in video. Note how the issue completely disappears and the favicon is shown correctly in the very same session when I simply disable that new feature and re-run the manual suspension. Note this also occurs with auto suspension. Hopefully this helps you to track down the issue.

DEMO:

[CollinChaffin]

Hey just wanted to report in initial testing that last night's commit 4e4d20e appears to have possibly finally resolved the favicon issues, even when re-enabling the built-in-chrome tab discarding! From the # of commits the last few days it is clear you've been very busy! Nice job!

EDIT: One correction: All the MANUAL suspension actions I have tried, whether through the panel or context menu, and surprisingly even old prior suspended tabs in sessions restored through SessionBuddy now, after restoring, perform one last refresh and correct their appearance and do seem resolved. HOWEVER--for some reason I just watched as a few tabs that performed an AUTOMATIC suspension wound up still suspending incorrectly to a blockhead icon. Of note, after seeing the promising results from manual suspensions, I have once again been running with the new option re-enabled to utilize Chrome's native discarding which may still be impacting the AUTO suspend. I will perform some more thorough testing of the AUTO portion later this AM and report back the results.

[mkz7]

UPDATE: I can confirm this DOES in fact now revolve around the code related to the Apply Chrome's built-in memory-saving when suspending option as shown here in video. Note how the issue completely disappears and the favicon is shown correctly in the very same session when I simply disable that new feature and re-run the manual suspension. Note this also occurs with auto suspension. Hopefully this helps you to track down the issue.

DEMO:

The option mentioned in the above 'fix' -- i.e., to uncheck "Apply Chrome's built-in memory saving when suspending" -- isn't displayed on my TGS Settings page.

'Where to' to find it?

[fwextensions]

@mkz7 which version of the extension do you have installed? If you right-click the TGS icon and select Options, and then go to About, the version number is at the top.

[CollinChaffin]

This is still not fixed as of commit e2d748c dated 11/14 even normal suspend operations are resulting in the blockhead generic favicon when that new switch for native discard is enabled.

[deanoemcke]

@CollinChaffin can you try the latest commit (v7.0.144) (v7.0.147)?
I have made some more changes around favicon handling and fixed at least one outstanding bug in this code.

[mkz7]

@mkz7 which version of the extension do you have installed? If you right-click the TGS icon and select Options, and then go to About, the version number is at the top.

[Re: I don't see "Apply Chrome's built-in memory saving when suspending."]

Thanks. I'm using v7.0.109 (on a Mac). (Don't versions update automatically?)

[mkz7]

@mkz7 I looked into Tabli. The issue is to do with how their extension is obtaining the favicon to display in their list. If they were to query the chrome tabs api, they would be able to get the correct favicon, but they don't do this.

@deanoemcke Just received this from the developer (Tabli):

"Tabli ❤️ The Great Suspender. A number of Tabli users also use The Great Suspender, an excellent Chrome extension that automatically suspends tabs you aren't using, freeing memory and CPU. This release of Tabli resolves a long-standing issue to ensure the correct icon and URL are shown for tabs suspended by the Great Suspender, and adds a little 💤 icon to indicate suspended tabs."

[deanoemcke]

@mkz7 Versions do update automatically, except that I'm doing a staggered rollout of newer versions so not everyone will get it at the same time.
That said, v7.109 IS the latest chrome webstore version. But it has known favicon issues. It also does NOT have the new "Apply Chrome's built-in memory saving when suspending." option. That is still in development and will be released shortly.
The latest development version of the extension should also have resolved all outstanding favicon issues (v7.0.147).

And awesome news from Tabli! Thanks for posting here.

[CollinChaffin]

Sorry @deanoemcke I replied on other issue but not here to confirm that as of latest commit things were looking much better and looked to be resolved (as far as this issue). However, I see that just yesterday you committed what looks like some more significant improvements so let me re-test quickly here and I will return and edit this post to confirm still fixed.

EDIT:

[danilaml]

Recently I've also started to experience this issue, however I'm on the latest stable version so I cannot confirm whether it was fixed in master or now. Perhaps an update is an order.

[guilleortas]

This is still an issue currently. I'm on Brave v1.42.97 Chromium: 104.0.5112.102 (official build) (64 bits)

[chaoscreater]

Still an issue on 7.1.12 on Thorium browser. Not using Apply Chrome's built-in memory-saving when suspending and the favicon is still being set to the extension's icon when suspending a tab.