Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with suspened and unsuspend caused by tab discarding #913

Closed
deanoemcke opened this issue Apr 7, 2019 · 1 comment
Closed

Issues with suspened and unsuspend caused by tab discarding #913

deanoemcke opened this issue Apr 7, 2019 · 1 comment

Comments

@deanoemcke
Copy link
Collaborator

Related to #901. Seems to only happen with certain chrome flags set, and after coming back to a session after a long period of time.

  1. When unsuspending multiple tabs with 'unsuspend selected', if there are 3 or more tabs selected, then the middle tabs will not unsuspend even though they are specifically given a chrome.tabs.update(tabId, unsuspendedUrl) command.

  2. Sometimes a tab that is suspending will be discarded before it finishes initialising the suspended state. This causes a bad favicon and title situation.

@deanoemcke
Copy link
Collaborator Author

Fix for 1. was to set tab property autoDiscardable to false when reloading. This seems to force the unsuspend. NOTE: The tabs autoDiscardable value is set back to true once the tab has finished unsuspending.

Fix for 2. was to trigger a tab init and check not only on the suspended tab status === complete event, but also on a discarded event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant