Ubuntu 20.04 Compile 5.15.24 Kernel - Compile Error

[nashford77]

You do not need the "sizeof(ar->mac_addr)" third function here - i removed it and it compiled fine:

drivers/net/wireless/ath/ath10k/core.c: In function ‘ath10k_core_probe_fw’:
drivers/net/wireless/ath/ath10k/core.c:4049:2: error: too many arguments to function ‘device_get_mac_address’
4049 | device_get_mac_address(ar->dev, ar->mac_addr, sizeof(ar->mac_addr));
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/ieee80211.h:20,
from ./include/net/mac80211.h:20,
from drivers/net/wireless/ath/ath10k/htt.h:16,
from drivers/net/wireless/ath/ath10k/core.h:18,
from drivers/net/wireless/ath/ath10k/core.c:19:
./include/linux/etherdevice.h:35:5: note: declared here
35 | int device_get_mac_address(struct device *dev, char *addr);
| ^~~~~~~~~~~~~~~~~~~~~~

[greearb]

It must be conflicting with some patch that ubuntu pulls into their kernel that is not in mainline 5.15 kernel,
as my 5.15 kernel compiles for me...

[nashford77]

Also ref to power save - I set performance governor on all cores - didn't make a diff. Still the same.

…

On Mon, Feb 21, 2022, 12:26 PM Ben Greear ***@***.***> wrote: It must be conflicting with some patch that ubuntu pulls into their kernel that is not in mainline 5.15 kernel, as my 5.15 kernel compiles for me... — Reply to this email directly, view it on GitHub <#201 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFSSJU4X5AVPMOXMV4TH2C3U4JYUHANCNFSM5O5POBNQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[greearb]

You need to google 'wifi power save' and read up a bit, it has nothing to do with CPU power save/performance. I don't know why you have issues with 160Mhz. Does 80Mhz work better?

…

On 2/21/22 9:30 AM, nashford77 wrote: Also ref to power save - I set performance governor on all cores - didn't make a diff. Still the same. On Mon, Feb 21, 2022, 12:26 PM Ben Greear ***@***.***> wrote: > It must be conflicting with some patch that ubuntu pulls into their kernel > that is not in mainline 5.15 kernel, > as my 5.15 kernel compiles for me... > > — > Reply to this email directly, view it on GitHub > <#201 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFSSJU4X5AVPMOXMV4TH2C3U4JYUHANCNFSM5O5POBNQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you authored the thread.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_greearb_ath10k-2Dct_issues_201-23issuecomment-2D1047101747&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=HYKqseB9xg-u2kz3egvegqfgyXnEBhQotXfR3iCfdgM&m=EnMgdBrrOrzL-Cl6G41CKiXI5yomxNKZZ7bOQAX3pbY&s=pOzODt4iYArEpm_6tJnAiSWMRtmgDv3EyC0TEdkJCDY&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AACHNKW2NNXCXQBAQDHX4MDU4JZFBANCNFSM5O5POBNQ&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=HYKqseB9xg-u2kz3egvegqfgyXnEBhQotXfR3iCfdgM&m=EnMgdBrrOrzL-Cl6G41CKiXI5yomxNKZZ7bOQAX3pbY&s=n4m2NiRpX4HCeuVKyIo4tbTd0VctTt9faHhUgvtA79c&e=>. Triage notifications on the go with GitHub Mobile for iOS <https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=HYKqseB9xg-u2kz3egvegqfgyXnEBhQotXfR3iCfdgM&m=EnMgdBrrOrzL-Cl6G41CKiXI5yomxNKZZ7bOQAX3pbY&s=AeuDMOdqpkjw9xfwKdwSYV-ELEi3gnts_t-TH__D6_Y&e=> or Android <https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=HYKqseB9xg-u2kz3egvegqfgyXnEBhQotXfR3iCfdgM&m=EnMgdBrrOrzL-Cl6G41CKiXI5yomxNKZZ7bOQAX3pbY&s=zj4c2pj77Zi0itvUr5HlYYFSAfHxN-9kdC080Ub9xVc&e=>. You are receiving this because you commented.Message ID: ***@***.***>

-- Ben Greear ***@***.***> Candela Technologies Inc http://www.candelatech.com