Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 17 for the SonarQube scan #17

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Use Java 17 for the SonarQube scan #17

merged 1 commit into from
Nov 6, 2023

Conversation

utarwyn
Copy link
Member

@utarwyn utarwyn commented Oct 6, 2023

Duplicate of green-code-initiative/creedengo-rules-specifications#229

Sorry for the redundant PR but I can't push to main branch on this plugin, @dedece35 you know why?

@utarwyn utarwyn added the 🏗️ refactoring refactoring for best practices label Oct 6, 2023
@utarwyn utarwyn requested a review from dedece35 October 6, 2023 21:10
@utarwyn utarwyn self-assigned this Oct 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@utarwyn
Copy link
Member Author

utarwyn commented Oct 31, 2023

@dedece35 any news on this? also about permissions?

@dedece35
Copy link
Member

dedece35 commented Nov 1, 2023

@dedece35 any news on this? also about permissions?

I checked rigths and core-team have "maintener" rigths. You are in "core" team.
But no PR could be merged directly without at most one reviewer. If you want to do this anyway, you have to check the checkbox "merge without waiting for requirements to be met", and then click on "merge pull request".
Do you have this checkbox and this button ?
We could discuss about it directly next week if you want.

@utarwyn
Copy link
Member Author

utarwyn commented Nov 6, 2023

Seen with @dedece35, I now have the checkbox. Thank you!

@utarwyn utarwyn merged commit 81b8f52 into main Nov 6, 2023
3 checks passed
@utarwyn utarwyn deleted the sonar-scanner-jdk-17 branch November 6, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ refactoring refactoring for best practices
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants