(fix): Warning for missing values now matching correct counts [skip ci]

green-coding-solutions · Dec 16, 2024 · 04cc436 · 04cc436
1 parent 77a7974
commit 04cc436
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/frontend/js/helpers/phase-stats.js b/frontend/js/helpers/phase-stats.js
@@ -201,9 +201,15 @@ const renderCompareChartsForPhase = (phase_stats_object, phase='[RUNTIME]', run_
             /* END BLOCK LABELS*/
 
             if (
-                (phase_stats_object.comparison_identifiers.length == 2 && detail_data['data'][phase_stats_object.comparison_identifiers[0]]?.values?.length != detail_data['data'][phase_stats_object.comparison_identifiers[1]]?.values?.length)
+                (phase_stats_object.comparison_identifiers.length == 2
+                    && (
+                        detail_data['data'][phase_stats_object.comparison_identifiers[0]]?.values?.includes(null)
+                        || detail_data['data'][phase_stats_object.comparison_identifiers[0]]?.values == null
+                        || detail_data['data'][phase_stats_object.comparison_identifiers[0]].values.includes(null)
+                    )
+                )
                 ||
-                (phase_stats_object.comparison_identifiers.length == 1 && detail_data['data'][phase_stats_object.comparison_identifiers[0]]?.values?.length != run_count)
+                (phase_stats_object.comparison_identifiers.length == 1 && detail_data['data'][phase_stats_object.comparison_identifiers[0]]?.values?.includes(null))
             ) {
                 showWarning(phase, `${metric_name} ${detail_name} was missing from at least one comparison.`)
             }