WIP: Heap Sort #18
Draft
WIP: Heap Sort #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinkline
reviewed
Apr 24, 2023
| //heap sort | ||
| //TODO: @bluesign: we need to add some generic comparators | ||
| pub fun comparatorUInt64(a:AnyStruct, b:AnyStruct, _ reverse:Bool):Bool{ |
There was a problem hiding this comment.
Should we follow what other languages so here and return -1, 0, or 1 depending on how the two elements compare?
| } | ||
|
|
||
| pub fun heapSort(_ arr: &[AnyStruct], _ comparator: ((AnyStruct, AnyStruct, Bool): Bool), _ reverse:Bool ) { |
There was a problem hiding this comment.
Passing in a function to do the comparison makes a lot of sense to me. It would be great if cadence could expose this kind of interface in general but that seems like a much more involved task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.