Fixes a runtime error that occurs when deep-merging fragments #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where inconsistent results occur based on the fragment's declared order.
I fixed a similar issue in #_453, but in that case the fragment was nested, whereas this case is not.
This fails:
While this is not:
My guess is that
deep-merge
doesn't handle the situation where nil comes in instead of map.It can be
::null
, or it can actually benil
.It depends on whether the object that catches bubbled-up error is non-null or not.