fix(greenbids,analytics): fetch bidder params when bid is valid #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/greenbidsAnalyticsAdapter.js
Outdated
| timeoutBids.forEach(badBid => { | ||
| Object.assign( | ||
| biddersSubMessages.get((badBid.adUnitCode, badBid.bidder)) || {}, | ||
| { isTimeout: true } |
There was a problem hiding this comment.
question: seems that hasBid: false should be added in case of timeout
modules/greenbidsAnalyticsAdapter.js
Outdated
| bidsReceived, | ||
| noBids | ||
| } = auctionEndArgs; | ||
| const timeoutBids = (cachedAuction || this.getCachedAuction(auctionId)).timeoutBids || []; |
There was a problem hiding this comment.
question: the auctionId is cached twice here. Could we cache it once at handleAuctionInit and then reuse?
jbogp
reviewed
Sep 17, 2024
|
|
||
| // Keep only bidders that received a bid request and enrich the message |
There was a problem hiding this comment.
I don't understand how this line relates to the comment, and why it's needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.