By file linting for more details ... #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernricks
requested changes
Aug 25, 2020
There was a problem hiding this comment.
Just a small fix for raising an exception. See greenbone/ospd#321 and in more detail https://docs.python.org/3/reference/simple_stmts.html#the-raise-statement
Besides that I really like that change 👍 I've thought about that too several times.
autohooks/plugins/pylint/pylint.py
Outdated
| @@ -27,9 +27,9 @@ | |||
|
|
|||
| def check_pylint_installed(): | |||
| try: | |||
| import pylint # pylint: disable=import-outside-toplevel | |||
| import pylint # pylint: disable=import-outside-toplevel, disable=unused-import | |||
| except ImportError: | |||
There was a problem hiding this comment.
Suggested change
| except ImportError: | |
| except ImportError as e: |
autohooks/plugins/pylint/pylint.py
Outdated
Comment on lines
32
to
35
| raise Exception from ImportError( | ||
| 'Could not find pylint. Please add pylint to your python ' | ||
| 'environment' | ||
| ) |
There was a problem hiding this comment.
Suggested change
| raise Exception from ImportError( | |
| 'Could not find pylint. Please add pylint to your python ' | |
| 'environment' | |
| ) | |
| raise Exception( | |
| 'Could not find pylint. Please add pylint to your python ' | |
| 'environment' | |
| ) from e |
autohooks/plugins/pylint/pylint.py
Outdated
| args.extend(arguments) | ||
| args.append(str(f.absolute_path())) | ||
| status = subprocess.call(args) | ||
| # str_files = ', '.join([str(f.path) for f in files]) |
There was a problem hiding this comment.
Suggested change
| # str_files = ', '.join([str(f.path) for f in files]) |
bjoernricks
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
By file linting ...
Why?
Had visual issues in the console, when many files have been linted (maybe i will look hat the autohooks repo and edit it as well ...)
Checklist: