Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandatory hooks #28

Merged
merged 5 commits into from
Sep 13, 2019
Merged

Mandatory hooks #28

merged 5 commits into from
Sep 13, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Sep 13, 2019

Fail git hook if a plugin can't be executed.

References #25

Checklist:

  • [n/a] Tests
  • CHANGELOG Entry
  • [n/a] Documentation

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #28 into master will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   39.67%   39.49%   -0.19%     
==========================================
  Files          12       12              
  Lines         431      433       +2     
==========================================
  Hits          171      171              
- Misses        260      262       +2
Impacted Files Coverage Δ
autohooks/precommit/run.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94abfd...4711c8d. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #28 into master will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage    40.5%   40.31%   -0.19%     
==========================================
  Files          12       12              
  Lines         437      439       +2     
==========================================
  Hits          177      177              
- Misses        260      262       +2
Impacted Files Coverage Δ
autohooks/precommit/run.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bb841...d67f78f. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review September 13, 2019 07:58
If an error occurs during plugin execution fail the complete hook. It
still can be ignored by using `git commit --no-verify`.

Update error messages to display some hints.
CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Michael Wiegand <wiegandm@users.noreply.github.com>
@bjoernricks bjoernricks merged commit 7c72860 into greenbone:master Sep 13, 2019
@bjoernricks bjoernricks deleted the mandatory-hooks branch September 13, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants