Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry mode #29

Merged
merged 5 commits into from
Sep 13, 2019
Merged

Poetry mode #29

merged 5 commits into from
Sep 13, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Sep 13, 2019 •
edited
Loading

Checklist:

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #29 into master will increase coverage by 0.82%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #29      +/-   ##
=========================================
+ Coverage   39.67%   40.5%   +0.82%     
=========================================
  Files          12      12              
  Lines         431     437       +6     
=========================================
+ Hits          171     177       +6     
  Misses        260     260
Impacted Files Coverage Δ
autohooks/setting.py 100% <100%> (ø) ⬆️
autohooks/template.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94abfd...3821443. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #29 into master will increase coverage by 0.82%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #29      +/-   ##
=========================================
+ Coverage   39.67%   40.5%   +0.82%     
=========================================
  Files          12      12              
  Lines         431     437       +6     
=========================================
+ Hits          171     177       +6     
  Misses        260     260
Impacted Files Coverage Δ
autohooks/template.py 100% <100%> (ø) ⬆️
autohooks/setting.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94abfd...242cb9d. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review September 13, 2019 08:54
wiegandm
wiegandm approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@wiegandm wiegandm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test the poetry integration, but adding the mode looks like a sensible choice to me.

@bjoernricks
Copy link
Contributor Author

I did not test the poetry integration, but adding the mode looks like a sensible choice to me.

I did a quick test and it worked for me

@bjoernricks bjoernricks merged commit d3bb841 into greenbone:master Sep 13, 2019
@bjoernricks bjoernricks deleted the poetry-mode branch September 13, 2019 10:14
@bjoernricks bjoernricks mentioned this pull request Sep 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiegandm wiegandm wiegandm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @wiegandm