-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added type hints/annotations to all methods #32
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 40.31% 40.57% +0.25%
==========================================
Files 12 12
Lines 439 456 +17
==========================================
+ Hits 177 185 +8
- Misses 262 271 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why you did remove Mode.get_effective_mode. But besides it looks very very good again. Thank you very much!
I am relatively sure, that the function is not necessary in the one case it was used. |
You are right currently the behavior is the same without the get_effective_mode method. But it has a semantic meaning which I don't want to remove (currently). Additionally it would have been better to remove the method in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Added type hints/annotations to all methods
Checklist: