-
Notifications
You must be signed in to change notification settings - Fork 99
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change: Handle delta results with changed severity, qod and hostname (#…
…3902) In addition to description differences, differences in severity, qod or hostname are considered as a change in delta results comparison.
- Loading branch information
1 parent
9275bbd
commit 564ecf2
Showing
4 changed files
with
164 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* Copyright (C) 2023 Greenbone AG | ||
| * | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Affero General Public License | ||
| * as published by the Free Software Foundation, either version 3 | ||
| * of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| import withSvgIcon from './withSvgIcon'; | ||
|
|
||
| import {ReactComponent as Icon} from './svg/delta_second.svg'; | ||
|
|
||
| const DeltaDifferenceIcon = withSvgIcon()(Icon); | ||
|
|
||
| export default DeltaDifferenceIcon; | ||
|
|
||
| // vim: set ts=2 sw=2 tw=80: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* Copyright (C) 2019-2023 Greenbone AG | ||
| * | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Affero General Public License | ||
| * as published by the Free Software Foundation, either version 3 | ||
| * of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import {rendererWith} from 'web/utils/testing'; | ||
| import Row from '../row'; | ||
| import Result from 'gmp/models/result'; | ||
|
|
||
| describe('Delta reports V2 with changed severity, qod and hostname', () => { | ||
| const {render} = rendererWith(); | ||
|
|
||
| test('should render Delta Difference icon', () => { | ||
| const entity = Result.fromElement({ | ||
| _id: '101', | ||
| name: 'Result 1', | ||
| host: {__text: '123.456.78.910', hostname: 'foo'}, | ||
| port: '80/tcp', | ||
| severity: 10.0, | ||
| qod: {value: 80}, | ||
| notes: [], | ||
| overrides: [], | ||
| tickets: [], | ||
| delta: { | ||
| result: { | ||
| _id: '102', | ||
| name: 'Result 2', | ||
| host: {__text: '123.456.78.910', hostname: 'bar'}, | ||
| port: '80/tcp', | ||
| severity: 2.6, | ||
| qod: {value: 70}, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const {getAllByTestId} = render(<Row entity={entity} />); | ||
| const icons = getAllByTestId('svg-icon'); | ||
|
|
||
| expect(icons.length).toEqual(3); | ||
| expect(icons[0]).toHaveAttribute('title', 'Severity is changed from 2.6.'); | ||
| expect(icons[1]).toHaveAttribute('title', 'QoD is changed from 70.'); | ||
| expect(icons[2]).toHaveAttribute('title', 'Hostname is changed from bar.'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('Delta reports V2 with same severity, qod and hostname', () => { | ||
| const {render} = rendererWith(); | ||
|
|
||
| test('should not render Delta Difference icon', () => { | ||
| const entity = Result.fromElement({ | ||
| _id: '101', | ||
| name: 'Result 1', | ||
| host: {__text: '123.456.78.910', hostname: 'foo'}, | ||
| port: '80/tcp', | ||
| severity: 10.0, | ||
| qod: {value: 80}, | ||
| notes: [], | ||
| overrides: [], | ||
| tickets: [], | ||
| delta: { | ||
| result: { | ||
| _id: '102', | ||
| name: 'Result 2', | ||
| host: {__text: '123.456.78.910', hostname: 'foo'}, | ||
| port: '80/tcp', | ||
| severity: 10.0, | ||
| qod: {value: 80}, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const {queryAllByTestId} = render(<Row entity={entity} />); | ||
| const icons = queryAllByTestId('svg-icon'); | ||
|
|
||
| expect(icons.length).toBe(0); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters