Skip to content

Commit

Permalink
Fix: Fix handling of missing delta result fields
Browse files Browse the repository at this point in the history
The delta icons for severity, QoD and hostname now handle missing values
for the delta result correctly.
  • Loading branch information
timopollmeier committed Oct 24, 2023
1 parent d7ec5c7 commit a51b65f
Showing 1 changed file with 11 additions and 12 deletions.
23 changes: 11 additions & 12 deletions src/web/pages/results/row.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ const Row = ({
entity.overrides.filter(override => override.isActive()).length > 0;
const hasTickets = entity.tickets.length > 0;
const deltaSeverity = entity.delta?.result?.severity;
const deltaHostname = entity.delta?.result?.host.hostname;
const deltaQoD = entity.delta?.result?.qod.value;
const deltaHostname = entity.delta?.result?.host?.hostname;
const deltaQoD = entity.delta?.result?.qod?.value;
return (
<TableRow>
{delta && (
Expand Down Expand Up @@ -105,20 +105,19 @@ const Row = ({
<TableData>
<IconDivider>
<SeverityBar severity={entity.severity} />
{isDefined(entity.delta?.result) &&
entity.severity !== deltaSeverity && (
<DeltaDifferenceIcon
title={_('Severity is changed from {{deltaSeverity}}.', {
deltaSeverity,
})}
/>
)}
{isDefined(deltaSeverity) && entity.severity !== deltaSeverity && (
<DeltaDifferenceIcon
title={_('Severity is changed from {{deltaSeverity}}.', {
deltaSeverity,
})}
/>
)}
</IconDivider>
</TableData>
<TableData align="end">
<IconDivider>
<Qod value={entity.qod.value} />
{isDefined(entity.delta?.result) && entity.qod.value !== deltaQoD && (
{isDefined(deltaQoD) && entity.qod.value !== deltaQoD && (
<DeltaDifferenceIcon
title={_('QoD is changed from {{deltaQoD}}.', {deltaQoD})}
/>
Expand All @@ -141,7 +140,7 @@ const Row = ({
{host.hostname.length > 0 && (
<span title={host.hostname}>{shorten(host.hostname, 40)}</span>
)}
{isDefined(entity.delta?.result) &&
{isDefined(deltaHostname) &&
deltaHostname.length > 0 &&
host.hostname !== deltaHostname && (
<DeltaDifferenceIcon
Expand Down

0 comments on commit a51b65f

Please sign in to comment.