Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for undefined report formats on report detailspage #2367

Merged
merged 5 commits into from
Aug 6, 2020

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp requested review from sarahd93 and a team August 6, 2020 14:01
@swaterkamp swaterkamp self-assigned this Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #2367 into gsa-20.08 will increase coverage by 0.16%.
The diff coverage is 85.34%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2367      +/-   ##
=============================================
+ Coverage      52.76%   52.92%   +0.16%     
=============================================
  Files           1070     1070              
  Lines          25789    25830      +41     
  Branches        7312     7356      +44     
=============================================
+ Hits           13607    13671      +64     
+ Misses         11058    11042      -16     
+ Partials        1124     1117       -7     
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/web/components/error/errorpanel.js 100.00% <ø> (ø)
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
gsa/src/web/pages/policies/detailspage.js 100.00% <ø> (ø)
gsa/src/web/pages/policies/row.js 100.00% <ø> (ø)
gsa/src/web/pages/portlists/detailspage.js 34.48% <ø> (ø)
gsa/src/web/pages/portlists/row.js 55.55% <ø> (ø)
gsa/src/web/pages/reportformats/detailspage.js 33.33% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc8f34...35352fa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants