Drop dynamic severity classes #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
added a commit
to janowagner/gvm-libs
that referenced
this pull request
Sep 9, 2020
This is not required anymore and can be removed after greenbone/gsa#2448 is applied as well as a backport of that PR to the gsa master branch.
2 tasks
|
I am a bit surprised that no tests had to be adjusted. @janowagner did you check all charts if they still work? |
Indeed this code was no covered by tests. I checked all charts manually and all looked fine. |
bjoernricks
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The support for multiple severity class ranges is removed.
There is now only one classification scheme (then one previously
called "nist"). Actually there was only one other classification scheme called
"pci-dss". It wasn't used or needed.
For the user, this essentially means that in "My Settings", the option
to select a severity classification scheme is not there anymore and that
the default is now applied mandatory.
This PR requires: greenbone/gvmd#1288
Why:
Removing the overhead about a dynamic handling where actually only static
class ranges are used simplifies code.
How:
Basically all aspects are removed, on gsa side, and on gvmd side.
While gvmd appears pretty clean now, in gsa there are some special
handlings with an old range style due to compatibility with older dashboard elements.
Checklist: