Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CVSS v3 Calculator. #2536

Merged
merged 31 commits into from
Nov 1, 2020
Merged

Added CVSS v3 Calculator. #2536

merged 31 commits into from
Nov 1, 2020

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Oct 28, 2020 •
edited
Loading

What:

Adding the CVSS v3(.1) Calculator to the GSA Help Page.
It works like the CVSS v2 Calculator (for now), except the score is calculated on the userside and not by gmp.

Why:

CVSS v2 will be deprecated and is not up to date anymore.

How:

Checklist:

@y0urself y0urself changed the title Added CVSS v3 support. Added CVSS v3 Calculator. Oct 28, 2020
bjoernricks
bjoernricks reviewed Oct 29, 2020
View reviewed changes
gsa/src/gmp/parser.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 29, 2020 •
edited
Loading

Codecov Report

Merging #2536 into gsa-21.04 will increase coverage by 0.59%.
The diff coverage is 97.91%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2536      +/-   ##
=============================================
+ Coverage      53.07%   53.66%   +0.59%     
=============================================
  Files           1071     1072       +1     
  Lines          25848    26202     +354     
  Branches        7350     7465     +115     
=============================================
+ Hits           13719    14062     +343     
- Misses         11012    11022      +10     
- Partials        1117     1118       +1
Impacted Files Coverage Δ
gsa/src/gmp/parser.js 97.77% <ø> (-1.39%) ⬇️
gsa/src/web/pages/extras/cvsscalculatorpage.js 91.39% <91.66%> (-3.34%) ⬇️
gsa/src/gmp/parser/cvss.js 98.71% <98.71%> (ø)
gsa/src/gmp/models/cve.js 98.07% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43325c...f8c4079. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review October 29, 2020 17:16
@y0urself y0urself requested a review from a team October 29, 2020 17:16
bjoernricks
bjoernricks reviewed Oct 30, 2020
View reviewed changes
gsa/src/gmp/parser.js Outdated Show resolved Hide resolved
bjoernricks
bjoernricks reviewed Oct 30, 2020
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Just one invalid change has slipped in.

@y0urself
Copy link
Member Author

y0urself commented Nov 1, 2020

So this PR implemented the new feature for CVSS v3 calculation.
Maybe we need to adjust the UI later on ...
Maybe we should add a test, that validates the calculated scores for all possible vectors?

@bjoernricks
Copy link
Contributor

Maybe we should add a test, that validates the calculated scores for all possible vectors?

You are always free to add as much tests as you think is required to validate the functionality.

Maybe we need to adjust the UI later on ...

Maybe we should ask for some feedback internally.

@bjoernricks bjoernricks merged commit cd01ce4 into greenbone:gsa-21.04 Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y0urself @bjoernricks