Background for login page #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The svg label doesn't show the correct font. Therefore just use the png version.
Use a new design for the login page background.
Using the Greenbone green will hide the link at the login page now. Therefore just use same color as non-visited link (gray).
The visited link color has changed.
Use screen instead of the returned query functions of render. Also remove the snapshot test which is very flacky.
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2756 +/- ##
=============================================
+ Coverage 53.71% 53.84% +0.13%
=============================================
Files 1072 1075 +3
Lines 26223 26206 -17
Branches 7474 7475 +1
=============================================
+ Hits 14086 14111 +25
+ Misses 11019 10979 -40
+ Partials 1118 1116 -2
Continue to review full report at Codecov.
|
janwerremeyer
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add new background for login page
Why:
We designed a new green version for the background.
How:
Checklist: