Fix setting comments of BPM nodes #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2781 +/- ##
=============================================
+ Coverage 53.71% 53.86% +0.14%
=============================================
Files 1072 1075 +3
Lines 26223 26210 -13
Branches 7474 7477 +3
=============================================
+ Hits 14086 14117 +31
+ Misses 11019 10977 -42
+ Partials 1118 1116 -2
Continue to review full report at Codecov.
|
bjoernricks
reviewed
Mar 9, 2021
|
Afaik we don't have a testing concept for dialogs, yet. |
bjoernricks
approved these changes
Mar 10, 2021
|
I'll think about how to test dialogs today. There might be something like a prototype for that in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix setting comments of BPM nodes.
Why:
The correct value in the textfield wasn't shown and got overwritten by each single key press.
How:
Create a node with a proper comment and edit a node's comment. In both cases the current comment value was shown to the user and after clicking save it was applied to the node.
Checklist: