Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show StartIcon for scheduled tasks on task listpage #2840

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Apr 7, 2021

What:
Show the start icon for scheduled tasks at the actions column the task listpage.

Why:
There is a discrepancy between task detailspage and listpage. The listpage didn't allow to manually start a task. The detailspage, however, offered this functionality. In order to avoid cumbersome searching for functions, the actions on the listpage and detailspage are nowequalized.

How:

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp requested review from y0urself, sarahd93, saberlynx and a team April 7, 2021 07:23
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #2840 (ecfa869) into gsa-21.04 (74a1fd3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-21.04    #2840   +/-   ##
==========================================
  Coverage      53.83%   53.83%           
==========================================
  Files           1075     1075           
  Lines          26226    26226           
  Branches        7491     7491           
==========================================
  Hits           14118    14118           
  Misses         10993    10993           
  Partials        1115     1115           
Impacted Files Coverage Δ
gsa/src/web/pages/tasks/actions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c1de0...ecfa869. Read the comment docs.

@swaterkamp swaterkamp self-assigned this Apr 7, 2021
@swaterkamp swaterkamp added the port-to-main Use mergifiy to port PR to master label Apr 7, 2021
@swaterkamp swaterkamp merged commit c22a231 into greenbone:gsa-21.04 Apr 7, 2021
swaterkamp added a commit that referenced this pull request Apr 7, 2021
Show StartIcon for scheduled tasks on task listpage (bp #2840)
@swaterkamp swaterkamp deleted the startSchedTask branch April 20, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants