Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting Radius secret key in dialog #2891

Merged
merged 6 commits into from
May 7, 2021

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Apr 30, 2021

What:
Use value of dialog internal state for secret key in radius dialog

Why:
The value was fixed and unchangeable.

How:

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp self-assigned this Apr 30, 2021
@swaterkamp swaterkamp changed the title Radius secret key Fix setting Radius secret key in dialog Apr 30, 2021
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #2891 (db2c8a2) into gsa-21.04 (74a1fd3) will increase coverage by 0.01%.
The diff coverage is 77.55%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2891      +/-   ##
=============================================
+ Coverage      53.83%   53.84%   +0.01%     
=============================================
  Files           1075     1075              
  Lines          26226    26246      +20     
  Branches        7491     7504      +13     
=============================================
+ Hits           14118    14133      +15     
- Misses         10993    10996       +3     
- Partials        1115     1117       +2     
Impacted Files Coverage Δ
gsa/src/web/pages/notes/dialog.js 4.87% <ø> (ø)
gsa/src/web/pages/nvts/solution.js 22.22% <0.00%> (-11.12%) ⬇️
gsa/src/web/pages/radius/dialog.js 66.66% <ø> (ø)
gsa/src/web/pages/results/dashboard/index.js 75.00% <ø> (ø)
gsa/src/web/pages/results/details.js 6.74% <0.00%> (-0.16%) ⬇️
gsa/src/web/pages/targets/details.js 10.00% <ø> (ø)
gsa/src/web/pages/usersettings/dialog.js 29.41% <ø> (ø)
gsa/src/web/pages/scanners/dialog.js 70.31% <66.66%> (+0.47%) ⬆️
gsa/src/gmp/models/certbund.js 100.00% <100.00%> (ø)
gsa/src/gmp/models/cpe.js 94.73% <100.00%> (-0.27%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004ed3e...db2c8a2. Read the comment docs.

@cfi-gb
Copy link
Member

cfi-gb commented Apr 30, 2021

Closes #2862 ?

@swaterkamp
Copy link
Member Author

This is a draft it has yet to be determined.

@swaterkamp swaterkamp added the port-to-main Use mergifiy to port PR to master label Apr 30, 2021
@swaterkamp swaterkamp marked this pull request as ready for review April 30, 2021 13:16
@swaterkamp swaterkamp requested a review from a team as a code owner April 30, 2021 13:16
@sarahd93 sarahd93 merged commit ecefb99 into greenbone:gsa-21.04 May 7, 2021
@swaterkamp swaterkamp added port-to-oldstable Use mergify to port PR to oldstable port-to-21.10 labels May 17, 2021
swaterkamp added a commit that referenced this pull request May 17, 2021
Fix setting Radius secret key in dialog (backport #2891)
swaterkamp added a commit that referenced this pull request May 17, 2021
Fix setting Radius secret key in dialog (backport #2891)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master port-to-oldstable Use mergify to port PR to oldstable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants