-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting Radius secret key in dialog #2891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2891 +/- ##
=============================================
+ Coverage 53.83% 53.84% +0.01%
=============================================
Files 1075 1075
Lines 26226 26246 +20
Branches 7491 7504 +13
=============================================
+ Hits 14118 14133 +15
- Misses 10993 10996 +3
- Partials 1115 1117 +2
Continue to review full report at Codecov.
|
Closes #2862 ? |
This is a draft it has yet to be determined. |
swaterkamp
force-pushed
the
radiusSecretKey
branch
from
April 30, 2021 13:15
99662a1
to
5937b82
Compare
sarahd93
approved these changes
May 7, 2021
swaterkamp
added
port-to-oldstable
Use mergify to port PR to oldstable
port-to-21.10
labels
May 17, 2021
This was referenced May 17, 2021
swaterkamp
added a commit
that referenced
this pull request
May 17, 2021
Fix setting Radius secret key in dialog (backport #2891)
2 tasks
swaterkamp
added a commit
that referenced
this pull request
May 17, 2021
Fix setting Radius secret key in dialog (backport #2891)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
port-to-main
Use mergifiy to port PR to master
port-to-oldstable
Use mergify to port PR to oldstable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Use value of dialog internal state for secret key in radius dialog
Why:
The value was fixed and unchangeable.
How:
Checklist: