Avoid cross origin forgery by using same-site cookie #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only allow access to the session cookie from the same site and not for third parties. This avoids CSRF attacks like like e.g. [BREACH](http://breachattack.com/). For more details please take a look at http://www.sjoerdlangkemper.nl/2016/04/14/preventing-csrf-with-samesite-cookie-attribute/
bjoernricks
added
port-to-main
Codecov Report
@@ Coverage Diff @@
## gsa-20.08 #2948 +/- ##
=============================================
+ Coverage 53.06% 53.74% +0.67%
=============================================
Files 1072 1072
Lines 25900 25908 +8
Branches 7372 7372
=============================================
+ Hits 13744 13923 +179
+ Misses 11034 10881 -153
+ Partials 1122 1104 -18
Continue to review full report at Codecov.
|
sarahd93
approved these changes
Jun 3, 2021
This was referenced Jun 3, 2021
bjoernricks
added a commit
that referenced
this pull request
Jun 3, 2021
Avoid cross origin forgery by using same-site cookie (backport #2948)
bjoernricks
added a commit
that referenced
this pull request
Jun 3, 2021
Avoid cross origin forgery by using same-site cookie (backport #2948)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Only allow access to the session cookie from the same site and not for
third parties.
Why:
This avoids CSRF attacks like like e.g.
BREACH.
For more details please take a look at
http://www.sjoerdlangkemper.nl/2016/04/14/preventing-csrf-with-samesite-cookie-attribute/
How:
Build new gsad and did take a look if the samesite cookie settings are present in the response of the login request. Additionally I've clicked though several pages to test if something did break.
Checklist: