-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly space and linebreak roles and groups in users table row #2949
Conversation
e4978d6
to
f151daf
Compare
Codecov Report
@@ Coverage Diff @@
## gsa-20.08 #2949 +/- ##
=============================================
+ Coverage 53.06% 53.74% +0.67%
=============================================
Files 1072 1072
Lines 25900 25909 +9
Branches 7372 7373 +1
=============================================
+ Hits 13744 13924 +180
+ Misses 11034 10881 -153
+ Partials 1122 1104 -18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properly space and linebreak roles and groups in users table row by not using the Divider component, which prevents wraps in flexbox. Instead add a , to each entry, except the last one, and let flexbox do it's magic (using the Layout component).
Why not using the wrap prop at the divider?
This might be a slightly misleading commit message. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me your solutions looks to complicated. If this can't be fixed with CSS (especially flexbox) alone it should be abstracted into a Divider like component.
Using |
f151daf
to
7a5466a
Compare
Properly space and linebreak roles and groups in users table row (backport #2949)
Properly space and linebreak roles and groups in users table row (backport #2949)
Properly space and linebreak roles and groups in users table row (backport #2949)
What:
Properly space and linebreak roles and groups in users table row by not using the Divider component, but HorizontalSep with a new wrap prop.
Why:
Adding too many roles and/or groups to a user grew the table row too wide and move parts of it out of screen. It was also not very readable even without growing > 100%/width
How:
Visually inspect how roles and groups are displayed. Add test for wrapped HorizontalSep
Checklist: