Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid caching of the index.html page #3082

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jul 23, 2021

When updating to a newer GSA version the client's browser may still have
an old version of that index.html file in its cache. In that case it
wont load the new JavaScript files. Therefore don't cache all URLs where
the index.html file is returned. This ensures the browers always loads
the newest JavaScript files.

AP-1550

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

When updating to a newer GSA version the client's browser may still have
an old version of that index.html file in its cache. In that case it
wont load the new JavaScript files. Therefore don't cache all URLs where
the index.html file is returned. This ensures the browers always loads
the newest JavaScript files.
@bjoernricks bjoernricks added port-to-stable Use mergifiy to port PR to stable port-to-main Use mergifiy to port PR to master labels Jul 23, 2021
@bjoernricks bjoernricks marked this pull request as ready for review July 23, 2021 08:10
@bjoernricks bjoernricks requested a review from a team as a code owner July 23, 2021 08:10
@sarahd93 sarahd93 merged commit 6284d57 into gsa-20.08 Jul 23, 2021
@sarahd93 sarahd93 deleted the bricks/dont-cache-index-html branch July 23, 2021 08:23
bjoernricks added a commit that referenced this pull request Jul 23, 2021
Avoid caching of the index.html page (backport #3082)
bjoernricks added a commit that referenced this pull request Jul 23, 2021
Avoid caching of the index.html page (backport #3082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master port-to-stable Use mergifiy to port PR to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants