Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AP1596] Add information about elevate credential being experimental #3091

Merged
merged 5 commits into from
Jul 27, 2021

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Jul 27, 2021

Added a new InfoIcon and use it to give information about the experimental feature of elevate credentials.

Tested with automated tests for the icon and manually check, whether the tooltip is shown upon hover.

infoicon
Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp added the port-to-main Use mergifiy to port PR to master label Jul 27, 2021
@swaterkamp swaterkamp self-assigned this Jul 27, 2021
@swaterkamp swaterkamp requested a review from a team as a code owner July 27, 2021 12:40
@swaterkamp swaterkamp changed the title Add information about elevate credential being experimental [AP1596] Add information about elevate credential being experimental Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #3091 (885906b) into gsa-21.04 (35da50f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-21.04    #3091   +/-   ##
==========================================
  Coverage      58.34%   58.34%           
==========================================
  Files           1076     1077    +1     
  Lines          26243    26244    +1     
  Branches        7489     7489           
==========================================
+ Hits           15311    15312    +1     
  Misses          9908     9908           
  Partials        1024     1024           
Impacted Files Coverage Δ
gsa/src/web/pages/targets/dialog.js 97.53% <ø> (ø)
gsa/src/web/components/icon/infoicon.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35da50f...885906b. Read the comment docs.

@sarahd93 sarahd93 merged commit a1c5180 into gsa-21.04 Jul 27, 2021
@sarahd93 sarahd93 deleted the swaterkamp/elevateCredInfo branch July 27, 2021 12:53
swaterkamp added a commit that referenced this pull request Jul 27, 2021
[AP1596] Add information about elevate credential being experimental (backport #3091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants