Improve displaying license #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the License class in an own ES module and adjust the class to the "normal" module behavior. When generated from response data the fromElement method should be used to parse the response and create the license data.
It is better to use the explicitly provided method for checking the capabilities of a user.
The License class only contains values as representation of a model and a model type. In the UI these values should be displayed with their more descriptive meaning.
Fix model and model type in license notification test and update the displayed text when the license is to expiring.
Codecov Report
@@ Coverage Diff @@
## main #3374 +/- ##
=======================================
Coverage 58.98% 58.99%
=======================================
Files 1045 1046 +1
Lines 25172 25183 +11
Branches 7178 7183 +5
=======================================
+ Hits 14848 14857 +9
- Misses 9363 9365 +2
Partials 961 961
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
swaterkamp
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Why:
For example trial and 450 are just values for the models. A model type can be virtual or hardware. But both values should not be displayed 1:1 to the user.
How:
Checklist: