Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsa-zh_CN.json #3811

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Update gsa-zh_CN.json #3811

merged 1 commit into from
Jul 24, 2023

Conversation

lyace2010
Copy link
Contributor

Add Chinese simplified localized dictionary

What

Update the gsa-zh_CN.json file content

Why

It turns out that the dictionary inside this file is empty

References

empty

Checklist

empty

  • Tests

add zh_CN locale dict
@lyace2010 lyace2010 requested a review from a team as a code owner July 22, 2023 15:52
@github-actions
Copy link

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@bjoernricks bjoernricks enabled auto-merge (squash) July 24, 2023 12:00
@bjoernricks bjoernricks merged commit a5b62ba into greenbone:main Jul 24, 2023
@bjoernricks
Copy link
Contributor

Hi @lyace2010, I just wanted to test your translations visually and at the moment we aren't able to use them because an entry for the selection in the user settings is missing. Therefore could you do me a favor and create an PR with an entry similar as https://github.com/greenbone/gsa/blob/main/src/gmp/locale/languages.js#L32-L35 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants