Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Appliance logo in the app header and page title - opensight #4150

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

daniele-mng
Copy link
Contributor

@daniele-mng daniele-mng commented Sep 5, 2024

What

  • Specific logo for each HW and VM appliance
  • Hide the theme switch in the header
  • Page title based on the appliance

References

GEA-589
GEA-602
GEA-697
GEA-699

Checklist

  • Tests

@daniele-mng daniele-mng requested a review from a team as a code owner September 5, 2024 09:53
Copy link

github-actions bot commented Sep 5, 2024

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 546254c.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

License Issues

package.json

PackageVersionLicenseIssue Type
@greenbone/opensight-ui-components^0.4.1-alpha6NullUnknown License
Allowed Licenses: 0BSD, AGPL-3.0-or-later, Apache-2.0, BlueOak-1.0.0, BSD-2-Clause, BSD-3-Clause-Clear, BSD-3-Clause, BSL-1.0, CAL-1.0, CC-BY-3.0, CC-BY-4.0, CC-BY-SA-4.0, CC0-1.0, EPL-2.0, GPL-2.0-only, GPL-2.0-or-later, GPL-2.0, GPL-3.0-or-later, ISC, LGPL-2.0-only, LGPL-2.0-or-later, LGPL-2.1-only, LGPL-2.1-or-later, LGPL-2.1, LGPL-3.0-only, LGPL-3.0, MIT, MPL-1.1, MPL-2.0, OFL-1.1, PSF-2.0, Python-2.0, Python-2.0.1, Unicode-DFS-2016, Unlicense

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@babel/runtime 7.25.6 🟢 6.5
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 1030 commit(s) and 17 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 2badge detected: InProgress
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Packaging⚠️ -1packaging workflow not detected
Security-Policy🟢 10security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions🟢 9detected GitHub workflow tokens with excessive permissions
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Fuzzing⚠️ 0project is not fuzzed
Vulnerabilities⚠️ 020 existing vulnerabilities detected
npm/@greenbone/opensight-ui-components 0.4.1-alpha6 UnknownUnknown
npm/react-i18next 15.0.2 🟢 3.8
Details
CheckScoreReason
Code-Review🟢 7Found 21/30 approved changesets -- score normalized to 7
Maintained🟢 1030 commit(s) and 16 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Binary-Artifacts🟢 7binaries present in source code
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Vulnerabilities⚠️ 0107 existing vulnerabilities detected
npm/react-select 5.8.1 🟢 5
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained⚠️ 22 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 2
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Vulnerabilities⚠️ 076 existing vulnerabilities detected
npm/@greenbone/opensight-ui-components ^0.4.1-alpha6 UnknownUnknown

Scanned Manifest Files

package-lock.json
  • @babel/runtime@7.25.6
  • @greenbone/opensight-ui-components@0.4.1-alpha6
  • react-i18next@15.0.2
  • react-select@5.8.1
  • @babel/runtime@7.24.6
  • @greenbone/opensight-ui-components@0.4.0
  • lucide-react@0.427.0
  • react-select@5.8.0
package.json
  • @greenbone/opensight-ui-components@^0.4.1-alpha6
  • @greenbone/opensight-ui-components@^0.4.0

Copy link

github-actions bot commented Sep 5, 2024

Conventional Commits Report

Type Number
Added 3
Bug Fixes 1

🚀 Conventional commits found.

@daniele-mng daniele-mng force-pushed the Add-Appliance-logo-in-the-app-header branch from e361dcf to 7cd202a Compare September 27, 2024 08:55
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.40%. Comparing base (bebbf43) to head (546254c).
Report is 6 commits behind head on opensight-ui.

Files with missing lines Patch % Lines
src/web/components/structure/header.jsx 0.00% 5 Missing ⚠️
src/web/routes.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           opensight-ui    #4150      +/-   ##
================================================
+ Coverage         64.34%   64.40%   +0.05%     
================================================
  Files              1107     1111       +4     
  Lines            103485   103652     +167     
  Branches           6457     6466       +9     
================================================
+ Hits              66592    66755     +163     
- Misses            36753    36757       +4     
  Partials            140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniele-mng daniele-mng force-pushed the Add-Appliance-logo-in-the-app-header branch from 34197bc to 6301c72 Compare September 30, 2024 13:37
@daniele-mng daniele-mng marked this pull request as draft September 30, 2024 14:49
@daniele-mng daniele-mng marked this pull request as ready for review October 1, 2024 08:59
@daniele-mng daniele-mng changed the title Add: Appliance logo in the app header Add: Appliance logo in the app header and page title - opensight Oct 1, 2024
@daniele-mng daniele-mng force-pushed the Add-Appliance-logo-in-the-app-header branch from e7dd5cd to 546254c Compare October 2, 2024 06:51
@daniele-mng daniele-mng merged commit 48a2292 into opensight-ui Oct 2, 2024
10 checks passed
@daniele-mng daniele-mng deleted the Add-Appliance-logo-in-the-app-header branch October 2, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants