Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple certificate formats for S/MIME (10.0) #231

Merged

Conversation

timopollmeier
Copy link
Member

The S/MIME email encryption will now accept the more common PEM X.509
certificate format in addition to PEM-encoded PKCS#7.

For this the new function gvm_gpg_import_many_types_from_string has been
added, which is also used internally in gvm_gpg_import_from_string and
when importing the certificates.

The S/MIME email encryption will now accept the more common PEM X.509
certificate format in addition to PEM-encoded PKCS#7.

For this the new function gvm_gpg_import_many_types_from_string has been
added, which is also used internally in gvm_gpg_import_from_string and
when importing the certificates.
@timopollmeier timopollmeier requested a review from a team May 17, 2019 15:11
@timopollmeier timopollmeier changed the title Allow multiple certificate formats for S/MIME Allow multiple certificate formats for S/MIME (10.0) May 17, 2019
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Just a couple minor formatting issues.

util/gpgmeutils.c Outdated Show resolved Hide resolved
util/gpgmeutils.c Outdated Show resolved Hide resolved
Co-Authored-By: Matt Mundell <32057441+mattmundell@users.noreply.github.com>
@timopollmeier timopollmeier requested a review from mattmundell May 29, 2019 14:43
@mattmundell mattmundell merged commit a4d775d into greenbone:gvm-libs-10.0 May 29, 2019
@timopollmeier timopollmeier deleted the smime-certificate-type-8.0 branch October 15, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants