Make solution and solution_type explicit for nvti #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
added
the
work in progress
This method adds a single tag to the tags list except it is a known tag where it is store into the explicit structure.
janowagner
force-pushed
the
resolve_tags
branch
from
3c9bd17 to
78b9d10
Compare
It turned out to be not necessary to have this function.
janowagner
removed
the
work in progress
2 tasks
mattmundell
approved these changes
Aug 11, 2019
| gchar * | ||
| nvti_solution (const nvti_t *n) | ||
| { | ||
| return (n ? n->solution : NULL); |
There was a problem hiding this comment.
Side note: you're the only one using parens with "return". Everywhere else uses "return 0;" style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means to add explicit methods to set and get solution and solution_type.