Check for opts params in osp_get_performance_ext() #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It checks that titles exists and it is not a null string. Also, it checks that start and end params are a valid epoch time value.
mattmundell
requested changes
Sep 26, 2019
Also, set the error for the other function for consistency.
mattmundell
requested changes
Sep 26, 2019
mattmundell
requested changes
Sep 26, 2019
jjnicola
force-pushed
the
check-getperf-params
branch
from
3f1884f to
d16f50b
Compare
mattmundell
approved these changes
Sep 26, 2019
|
@mattmundell Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It checks that titles exists and it is not a null string.
Also, it checks that start and end params are a valid epoch time value.