Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] Fix is_cidr6_block() and is_short_range_network() #338

Merged
merged 4 commits into from
May 25, 2020

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented May 22, 2020

Backport part of PR #337

Pointer p must be checked and it was pointing to a variable  already free()'ed.
@jjnicola jjnicola requested a review from mattmundell as a code owner May 22, 2020 13:52
@jjnicola jjnicola changed the title Fix is_cidr6_block() and is_short_range_network() [11.0] Fix is_cidr6_block() and is_short_range_network() May 22, 2020
CHANGELOG.md Outdated
@@ -22,6 +22,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Get details with get_reports in gmp_get_report_ext [#313](https://github.com/greenbone/gvm-libs/pull/313)
- Fix escaping entity attributes in print_entity_to_string [#318](https://github.com/greenbone/gvm-libs/pull/318)
- Fix is_cidr_block() [#323][https://github.com/greenbone/gvm-libs/pull/323]
- Fix is_cidr6_block() and is_short_range_network(). [#338][https://github.com/greenbone/gvm-libs/pull/338]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that these have [ instead of (

mattmundell
mattmundell previously approved these changes May 25, 2020
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fix the markdown?

@mattmundell mattmundell merged commit 9819a9e into greenbone:gvm-libs-11.0 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants