Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get interface used for routing to given destination #339

Merged
merged 12 commits into from
May 28, 2020

Conversation

ArnoStiefvater
Copy link
Member

@ArnoStiefvater ArnoStiefvater commented May 26, 2020

Add implementation for getting the interface which is used for routing to a given destination. If provided a source address is set to the address of the interface to use.

@ArnoStiefvater ArnoStiefvater requested a review from jjnicola as a code owner May 26, 2020 05:27
@ArnoStiefvater ArnoStiefvater force-pushed the routes branch 2 times, most recently from a0b1d68 to 773a996 Compare May 26, 2020 05:54
jjnicola
jjnicola previously approved these changes May 26, 2020
base/networking.c Outdated Show resolved Hide resolved
base/networking.c Outdated Show resolved Hide resolved
base/networking.c Outdated Show resolved Hide resolved
@mattmundell mattmundell self-requested a review May 26, 2020 08:19
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, to block merge.

Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual 👏 for the tests.

base/networking.c Show resolved Hide resolved
base/networking.c Outdated Show resolved Hide resolved
base/networking.c Outdated Show resolved Hide resolved
base/networking.c Outdated Show resolved Hide resolved
base/networking.c Show resolved Hide resolved
base/networking.h Outdated Show resolved Hide resolved
base/networking.c Show resolved Hide resolved
@mattmundell mattmundell merged commit c0e3c81 into greenbone:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants