Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation in is_hostname #353

Merged
merged 9 commits into from
Jun 23, 2020
Merged

Improve validation in is_hostname #353

merged 9 commits into from
Jun 23, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Jun 17, 2020 •
edited
Loading

Checklist:

@mattmundell mattmundell changed the title Improve is_hostname Improve validation in is_hostname Jun 17, 2020
@mattmundell mattmundell marked this pull request as ready for review June 22, 2020 16:41
@mattmundell mattmundell requested a review from jjnicola as a code owner June 22, 2020 16:41
@jjnicola jjnicola merged commit c6905ec into greenbone:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnicola jjnicola jjnicola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @jjnicola