Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade missing VTS to DEBUG, as it is not always available #355

Closed
wants to merge 1 commit into from

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Jun 23, 2020

Checklist:

@mattmundell mattmundell marked this pull request as ready for review June 23, 2020 16:27
@mattmundell mattmundell requested a review from jjnicola as a code owner June 23, 2020 16:27
@bjoernricks
Copy link
Contributor

Wouldn't it be possible to check the response of ospd-openvas and don't raise any message if it is still busy?

@mattmundell
Copy link
Contributor Author

Wouldn't it be possible to check the response of ospd-openvas and don't raise any message if it is still busy?

Not sure what you mean. This function is checking the response from ospd-openvas. If it's still busy we don't get element VTS so we print a debug. You're saying we should just leave out the debug?

@bjoernricks
Copy link
Contributor

Wouldn't it be possible to check the response of ospd-openvas and don't raise any message if it is still busy?

Not sure what you mean. This function is checking the response from ospd-openvas. If it's still busy we don't get element VTS so we print a debug. You're saying we should just leave out the debug?

I mean we should check the response of ospd-openvas and not raise any warning. ospd-openvas should return a specific status code with a specific message in this case which should be checked instead of relying on a missing vts element.

The current log message is confusing because 1. we do expect this behavior from ospd-openvas and 2. it is an implicit assumption that if vts is missing ospd-openvas is busy.

@mattmundell
Copy link
Contributor Author

Replaced by greenbone/gvmd#1159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants