Support new <alive_test_methods> OSP element #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was only possible to set the alive test as bitfield. Now we can set the methods via dedicated elements too.
Test target_append_as_xml. Test osp_target_add_alive_test_methods.
ArnoStiefvater
force-pushed
the
alive-test-xml
branch
from
8b429e2 to
df6674e
Compare
Use 'else if' instead second 'if' case.
jjnicola
reviewed
Oct 16, 2020
|
|
||
| int | ||
| finish_signal_on_queue (kb_t); | ||
| int finish_signal_on_queue (kb_t); |
There was a problem hiding this comment.
Not sure what is happening here with clang-format.
jjnicola
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add support for new OSP element for defining alive test methods via separate sub elements.
Why:
To have complete implementation of OSP.
How:
Added some tests.
Checklist: