Make more scanner preferences available for openvas-nasl #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all scanner settings/preferences which have defaults and are not dependent on CMake variables to gvm-libs. This way they are available for openvas-nasl too.
2 tasks
mattmundell
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Move all scanner settings/preferences which have defaults and are not dependent on CMake variables
to gvm-libs. This way they are available for openvas-nasl too.
Settings not moved to gvm-libs with reason
Defaults defined via CMake
Defined via openvas-nasl command line option
Not needed by openvas-nasl
Prerequisite to:
greenbone/openvas-scanner#614
Why:
To make the options available to scripts when run via openvas-nasl.
How:
Dump the prefs (
prefs_dump ()) with and without the PRs.openvas-nasl: has the additional options now.
openvas: no difference in preference settings.
Checklist: