Do not abort when log file not accessible #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function checks if a dir and log file exists and if we are able write to it. If this is not the case the function returns -1.
ArnoStiefvater
force-pushed
the
fix-logging
branch
from
1d67316 to
2ad2adf
Compare
If one of the domains has a log file or log directory which is not readable -1 is returned. This is not necessarily an abort worthy error if it is acceptable for the caller to have log messages logged to stderr instead.
2 tasks
ArnoStiefvater
requested review from
jjnicola and
mattmundell
as code owners
jjnicola
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Do not abort when trying to log to log file with wrong permissions.
If the error reported by setup_log_handlers is not handled the log domains with log files which can not be accessed will be ignored and some default is used instead.
Related to: greenbone/openvas-scanner#661
Why:
Fix greenbone/openvas-scanner#415.
How:
Checklist: